From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] stmmac: fix Transmit Underflow error
Date: Mon, 11 Apr 2011 12:56:39 -0700 (PDT) [thread overview]
Message-ID: <20110411.125639.104063930.davem@davemloft.net> (raw)
In-Reply-To: <1302513406-3758-3-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Mon, 11 Apr 2011 11:16:46 +0200
> On some old MAC chips without COE sometime the
> Transmit Underflow error is issued.
>
> The driver aborted all the transmission process
> and initialized it from scratch.
> This breaks the network activity as raised by Nachiketa
> on a SPEAr board.
>
> The patch is to fix this rare underflow event.
> The driver will only clear the interrupt and the Tx
> DMA will go out the Suspend state as soon as the
> descriptor is fetched again.
> The driver will continue to bump-up the DMA FIFO threshold
> that, indeed, helped somebody to prevent this kind of error
> in the past as well.
>
> Reported-by: Nachiketa Prachanda <nprachanda@ncomputing.com>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Applied.
next prev parent reply other threads:[~2011-04-11 19:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 9:16 [PATCH 1/3] stmmac: fixed dma lib build when turn-on the debug option Giuseppe CAVALLARO
2011-04-11 9:16 ` [PATCH 2/3] stmmac: fix open funct when exit on error Giuseppe CAVALLARO
2011-04-11 19:56 ` David Miller
2011-04-11 9:16 ` [PATCH 3/3] stmmac: fix Transmit Underflow error Giuseppe CAVALLARO
2011-04-11 19:56 ` David Miller [this message]
2011-04-11 19:56 ` [PATCH 1/3] stmmac: fixed dma lib build when turn-on the debug option David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411.125639.104063930.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).