* [PATCH] bonding:set save_load to 0 when initializing
@ 2011-04-08 13:40 Weiping Pan(潘卫平)
2011-04-11 18:56 ` Jay Vosburgh
0 siblings, 1 reply; 3+ messages in thread
From: Weiping Pan(潘卫平) @ 2011-04-08 13:40 UTC (permalink / raw)
To: fubar, andy; +Cc: netdev, linux-kernel, Weiping Pan
It is unnecessary to set save_load to 1 here,
as the tx_hashtbl is just kzalloced.
Signed-off-by: Weiping Pan(潘卫平) <panweiping3@gmail.com>
---
drivers/net/bonding/bond_alb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
index 9bc5de3..ab69e5a 100644
--- a/drivers/net/bonding/bond_alb.c
+++ b/drivers/net/bonding/bond_alb.c
@@ -176,7 +176,7 @@ static int tlb_initialize(struct bonding *bond)
bond_info->tx_hashtbl = new_hashtbl;
for (i = 0; i < TLB_HASH_TABLE_SIZE; i++) {
- tlb_init_table_entry(&bond_info->tx_hashtbl[i], 1);
+ tlb_init_table_entry(&bond_info->tx_hashtbl[i], 0);
}
_unlock_tx_hashtbl(bond);
--
1.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bonding:set save_load to 0 when initializing
2011-04-08 13:40 [PATCH] bonding:set save_load to 0 when initializing Weiping Pan(潘卫平)
@ 2011-04-11 18:56 ` Jay Vosburgh
2011-04-11 20:16 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Jay Vosburgh @ 2011-04-11 18:56 UTC (permalink / raw)
To: Weiping Pan(潘卫平); +Cc: andy, netdev, linux-kernel
>It is unnecessary to set save_load to 1 here,
>as the tx_hashtbl is just kzalloced.
>
>Signed-off-by: Weiping Pan(潘卫平) <panweiping3@gmail.com>
I don't think this will cause any behavioral change, but I'll
grant is more correct in intent (there's no load information to save at
this point).
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
>---
> drivers/net/bonding/bond_alb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
>index 9bc5de3..ab69e5a 100644
>--- a/drivers/net/bonding/bond_alb.c
>+++ b/drivers/net/bonding/bond_alb.c
>@@ -176,7 +176,7 @@ static int tlb_initialize(struct bonding *bond)
> bond_info->tx_hashtbl = new_hashtbl;
>
> for (i = 0; i < TLB_HASH_TABLE_SIZE; i++) {
>- tlb_init_table_entry(&bond_info->tx_hashtbl[i], 1);
>+ tlb_init_table_entry(&bond_info->tx_hashtbl[i], 0);
> }
>
> _unlock_tx_hashtbl(bond);
>--
>1.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bonding:set save_load to 0 when initializing
2011-04-11 18:56 ` Jay Vosburgh
@ 2011-04-11 20:16 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-04-11 20:16 UTC (permalink / raw)
To: fubar; +Cc: panweiping3, andy, netdev, linux-kernel
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Mon, 11 Apr 2011 11:56:47 -0700
>
>>It is unnecessary to set save_load to 1 here,
>>as the tx_hashtbl is just kzalloced.
>>
>>Signed-off-by: Weiping Pan(潘卫平) <panweiping3@gmail.com>
>
> I don't think this will cause any behavioral change, but I'll
> grant is more correct in intent (there's no load information to save at
> this point).
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-11 20:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-08 13:40 [PATCH] bonding:set save_load to 0 when initializing Weiping Pan(潘卫平)
2011-04-11 18:56 ` Jay Vosburgh
2011-04-11 20:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).