* [PATCH 1/2] caif: Bugfix use for_each_safe when removing list nodes.
2011-04-11 20:11 [PATCH 0/2] caif: Bugfixes sjur.brandeland
@ 2011-04-11 20:11 ` sjur.brandeland
2011-04-11 20:17 ` David Miller
2011-04-11 20:11 ` [PATCH 2/2] caif: performance bugfix - allow radio stack to prioritize packets sjur.brandeland
2011-04-11 20:17 ` [PATCH 0/2] caif: Bugfixes David Miller
2 siblings, 1 reply; 6+ messages in thread
From: sjur.brandeland @ 2011-04-11 20:11 UTC (permalink / raw)
To: davem; +Cc: netdev, sjurbren, Sjur Brændeland
From: Sjur Brændeland <sjur.brandeland@stericsson.com>
Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
---
net/caif/cfmuxl.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/caif/cfmuxl.c b/net/caif/cfmuxl.c
index 6bb338d..fc24974 100644
--- a/net/caif/cfmuxl.c
+++ b/net/caif/cfmuxl.c
@@ -205,9 +205,9 @@ static void cfmuxl_ctrlcmd(struct cflayer *layr, enum caif_ctrlcmd ctrl,
int phyid)
{
struct cfmuxl *muxl = container_obj(layr);
- struct list_head *node;
+ struct list_head *node, *next;
struct cflayer *layer;
- list_for_each(node, &muxl->srvl_list) {
+ list_for_each_safe(node, next, &muxl->srvl_list) {
layer = list_entry(node, struct cflayer, node);
if (cfsrvl_phyid_match(layer, phyid))
layer->ctrlcmd(layer, ctrl, phyid);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] caif: performance bugfix - allow radio stack to prioritize packets.
2011-04-11 20:11 [PATCH 0/2] caif: Bugfixes sjur.brandeland
2011-04-11 20:11 ` [PATCH 1/2] caif: Bugfix use for_each_safe when removing list nodes sjur.brandeland
@ 2011-04-11 20:11 ` sjur.brandeland
2011-04-11 20:17 ` David Miller
2011-04-11 20:17 ` [PATCH 0/2] caif: Bugfixes David Miller
2 siblings, 1 reply; 6+ messages in thread
From: sjur.brandeland @ 2011-04-11 20:11 UTC (permalink / raw)
To: davem; +Cc: netdev, sjurbren, Sjur Brændeland
From: Sjur Brændeland <sjur.brandeland@stericsson.com>
In the CAIF Payload message the Packet Type indication must be set to
UNCLASSIFIED in order to allow packet prioritization in the modem's
network stack. Otherwise TCP-Ack is not prioritized in the modems
transmit queue.
Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
---
net/caif/cfdgml.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/net/caif/cfdgml.c b/net/caif/cfdgml.c
index a4ce294..0382dec 100644
--- a/net/caif/cfdgml.c
+++ b/net/caif/cfdgml.c
@@ -13,6 +13,7 @@
#include <net/caif/cfsrvl.h>
#include <net/caif/cfpkt.h>
+
#define container_obj(layr) ((struct cfsrvl *) layr)
#define DGM_CMD_BIT 0x80
@@ -83,6 +84,7 @@ static int cfdgml_receive(struct cflayer *layr, struct cfpkt *pkt)
static int cfdgml_transmit(struct cflayer *layr, struct cfpkt *pkt)
{
+ u8 packet_type;
u32 zero = 0;
struct caif_payload_info *info;
struct cfsrvl *service = container_obj(layr);
@@ -94,7 +96,9 @@ static int cfdgml_transmit(struct cflayer *layr, struct cfpkt *pkt)
if (cfpkt_getlen(pkt) > DGM_MTU)
return -EMSGSIZE;
- cfpkt_add_head(pkt, &zero, 4);
+ cfpkt_add_head(pkt, &zero, 3);
+ packet_type = 0x08; /* B9 set - UNCLASSIFIED */
+ cfpkt_add_head(pkt, &packet_type, 1);
/* Add info for MUX-layer to route the packet out. */
info = cfpkt_info(pkt);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] caif: Bugfixes
2011-04-11 20:11 [PATCH 0/2] caif: Bugfixes sjur.brandeland
2011-04-11 20:11 ` [PATCH 1/2] caif: Bugfix use for_each_safe when removing list nodes sjur.brandeland
2011-04-11 20:11 ` [PATCH 2/2] caif: performance bugfix - allow radio stack to prioritize packets sjur.brandeland
@ 2011-04-11 20:17 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2011-04-11 20:17 UTC (permalink / raw)
To: sjur.brandeland; +Cc: netdev, sjurbren
From: sjur.brandeland@stericsson.com
Date: Mon, 11 Apr 2011 22:11:28 +0200
> These two patches applies cleanly to net-2.6 and net-next-2.6.
> Please apply as you see apropriate.
I put them in net-2.6
^ permalink raw reply [flat|nested] 6+ messages in thread