From: David Miller <davem@davemloft.net>
To: jdmason@kudzu.us
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] s2io: Fix warnings due to -Wunused-but-set-variable.
Date: Tue, 12 Apr 2011 11:21:14 -0700 (PDT) [thread overview]
Message-ID: <20110412.112114.104057205.davem@davemloft.net> (raw)
In-Reply-To: <20110412160002.GB1433@kudzu.us>
From: Jon Mason <jdmason@kudzu.us>
Date: Tue, 12 Apr 2011 11:00:04 -0500
> On Mon, Apr 11, 2011 at 04:01:43PM -0700, David Miller wrote:
>>
>> Most of these are cases where we are trying to read back a register
>> after a write to ensure completion.
>>
>> Simply pre-fixing the readl() or readq() with "(void)" is sufficient
>> because these are volatile operations and the compiler cannot eliminate
>> them just because no real assignment takes place.
>>
>> The case of free_rxd_blk()'s assignments to "struct buffAdd *ba" is a
>> real spurious assignment as this variable is completely otherwise
>> unused.
>>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
> Acked-by: Jon Mason <jdmason@kudzu.us>
Thanks for reviewing.
prev parent reply other threads:[~2011-04-12 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 23:01 [PATCH] s2io: Fix warnings due to -Wunused-but-set-variable David Miller
2011-04-12 16:00 ` Jon Mason
2011-04-12 18:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412.112114.104057205.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jdmason@kudzu.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).