From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: bruce.w.allan@intel.com, netdev@vger.kernel.org
Subject: Re: [net-next-2.6 PATCH] ethtool: time to blink provided in seconds not jiffies
Date: Tue, 12 Apr 2011 13:47:51 -0700 (PDT) [thread overview]
Message-ID: <20110412.134751.226779885.davem@davemloft.net> (raw)
In-Reply-To: <1302566234.5282.581.camel@localhost>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 12 Apr 2011 00:57:14 +0100
> On Mon, 2011-04-11 at 16:01 -0700, Bruce Allan wrote:
>> When blinking for a duration set by the user, the value specified is in
>> seconds but it is used as the number of jiffies in the timeout after which
>> the Physical ID indicator is deactivated. Fix by converting the timeout
>> to seconds.
>
> D'oh.
>
>> Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
> Acked-by: Ben Hutchings <bhutchings@solarflare.com>
Applied, thanks.
prev parent reply other threads:[~2011-04-12 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 23:01 [net-next-2.6 PATCH] ethtool: time to blink provided in seconds not jiffies Bruce Allan
2011-04-11 23:57 ` Ben Hutchings
2011-04-12 20:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412.134751.226779885.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=bruce.w.allan@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).