From: David Miller <davem@davemloft.net>
To: Joakim.Tjernlund@transmode.se
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: Do not wrap sysctl igmp_max_memberships in IP_MULTICAST
Date: Tue, 12 Apr 2011 14:00:16 -0700 (PDT) [thread overview]
Message-ID: <20110412.140016.189701267.davem@davemloft.net> (raw)
In-Reply-To: <1302601774-24289-1-git-send-email-Joakim.Tjernlund@transmode.se>
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Date: Tue, 12 Apr 2011 11:49:34 +0200
> controlling igmp_max_membership is useful even when IP_MULTICAST
> is off.
> Quagga(an OSPF deamon) uses multicast addresses for all interfaces
> using a single socket and hits igmp_max_membership limit when
> there are 20 interfaces or more.
> Always export sysctl igmp_max_memberships in proc, just like
> igmp_max_msf
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
I really like your commit message, a full justification and a
reference to existing similar behavior.
If only every patch submitter did this :-/
Applied, thanks!
next prev parent reply other threads:[~2011-04-12 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 9:49 [PATCH] net: Do not wrap sysctl igmp_max_memberships in IP_MULTICAST Joakim Tjernlund
2011-04-12 21:00 ` David Miller [this message]
2011-04-12 22:41 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412.140016.189701267.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Joakim.Tjernlund@transmode.se \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).