* [PATCH] net: Do not wrap sysctl igmp_max_memberships in IP_MULTICAST
@ 2011-04-12 9:49 Joakim Tjernlund
2011-04-12 21:00 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Joakim Tjernlund @ 2011-04-12 9:49 UTC (permalink / raw)
To: netdev; +Cc: Joakim Tjernlund
controlling igmp_max_membership is useful even when IP_MULTICAST
is off.
Quagga(an OSPF deamon) uses multicast addresses for all interfaces
using a single socket and hits igmp_max_membership limit when
there are 20 interfaces or more.
Always export sysctl igmp_max_memberships in proc, just like
igmp_max_msf
Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
---
net/ipv4/sysctl_net_ipv4.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
index d96c1da..9cc2824 100644
--- a/net/ipv4/sysctl_net_ipv4.c
+++ b/net/ipv4/sysctl_net_ipv4.c
@@ -306,7 +306,6 @@ static struct ctl_table ipv4_table[] = {
.mode = 0644,
.proc_handler = proc_do_large_bitmap,
},
-#ifdef CONFIG_IP_MULTICAST
{
.procname = "igmp_max_memberships",
.data = &sysctl_igmp_max_memberships,
@@ -314,8 +313,6 @@ static struct ctl_table ipv4_table[] = {
.mode = 0644,
.proc_handler = proc_dointvec
},
-
-#endif
{
.procname = "igmp_max_msf",
.data = &sysctl_igmp_max_msf,
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: Do not wrap sysctl igmp_max_memberships in IP_MULTICAST
2011-04-12 9:49 [PATCH] net: Do not wrap sysctl igmp_max_memberships in IP_MULTICAST Joakim Tjernlund
@ 2011-04-12 21:00 ` David Miller
2011-04-12 22:41 ` Joakim Tjernlund
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2011-04-12 21:00 UTC (permalink / raw)
To: Joakim.Tjernlund; +Cc: netdev
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Date: Tue, 12 Apr 2011 11:49:34 +0200
> controlling igmp_max_membership is useful even when IP_MULTICAST
> is off.
> Quagga(an OSPF deamon) uses multicast addresses for all interfaces
> using a single socket and hits igmp_max_membership limit when
> there are 20 interfaces or more.
> Always export sysctl igmp_max_memberships in proc, just like
> igmp_max_msf
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
I really like your commit message, a full justification and a
reference to existing similar behavior.
If only every patch submitter did this :-/
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: Do not wrap sysctl igmp_max_memberships in IP_MULTICAST
2011-04-12 21:00 ` David Miller
@ 2011-04-12 22:41 ` Joakim Tjernlund
0 siblings, 0 replies; 3+ messages in thread
From: Joakim Tjernlund @ 2011-04-12 22:41 UTC (permalink / raw)
To: David Miller; +Cc: netdev
David Miller <davem@davemloft.net> wrote on 2011/04/12 23:00:16:
>
> From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> Date: Tue, 12 Apr 2011 11:49:34 +0200
>
> > controlling igmp_max_membership is useful even when IP_MULTICAST
> > is off.
> > Quagga(an OSPF deamon) uses multicast addresses for all interfaces
> > using a single socket and hits igmp_max_membership limit when
> > there are 20 interfaces or more.
> > Always export sysctl igmp_max_memberships in proc, just like
> > igmp_max_msf
> >
> > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
>
> I really like your commit message, a full justification and a
> reference to existing similar behavior.
>
> If only every patch submitter did this :-/
Thanks, I really wish all my commit msgs are like the above.
Jocke
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-12 22:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-12 9:49 [PATCH] net: Do not wrap sysctl igmp_max_memberships in IP_MULTICAST Joakim Tjernlund
2011-04-12 21:00 ` David Miller
2011-04-12 22:41 ` Joakim Tjernlund
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).