From: Stephen Hemminger <shemminger@vyatta.com>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Ralph Hempel <ralph.hempel@lantiq.com>,
linux-mips@linux-mips.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] MIPS: lantiq: add ethernet driver
Date: Tue, 12 Apr 2011 16:54:24 -0700 [thread overview]
Message-ID: <20110412165424.0b6ba71a@nehalam> (raw)
In-Reply-To: <1302624675-18652-3-git-send-email-blogic@openwrt.org>
On Tue, 12 Apr 2011 18:11:14 +0200
John Crispin <blogic@openwrt.org> wrote:
> +
> +struct ltq_mii_priv {
> + struct ltq_eth_data *pldata;
> + struct resource *res;
> + struct net_device_stats stats;
You don't need to have private stats structure it is part
of net_device in recent kernels. In fact, since you don't
set .ndo_get_stats, the driver is getting the default function
which prints the values from network_device, not your priv structure.
Also, please consider adding basic ethtool support to
show speed/duplex and driver information.
--
prev parent reply other threads:[~2011-04-12 23:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1302624675-18652-1-git-send-email-blogic@openwrt.org>
2011-04-12 16:11 ` [PATCH 2/3] MIPS: lantiq: add ethernet driver John Crispin
2011-04-12 22:46 ` David Miller
2011-04-12 23:54 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412165424.0b6ba71a@nehalam \
--to=shemminger@vyatta.com \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=ralph.hempel@lantiq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).