From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: amit.salecha@qlogic.com, netdev@vger.kernel.org,
ameen.rahman@qlogic.com, sucheta.chakraborty@qlogic.com,
anirban.chakraborty@qlogic.com
Subject: Re: [PATCHv4 NEXT 1/1] net: ethtool support to configure number of channels
Date: Wed, 13 Apr 2011 11:31:24 -0700 (PDT) [thread overview]
Message-ID: <20110413.113124.59674252.davem@davemloft.net> (raw)
In-Reply-To: <1302718921.2873.1.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Wed, 13 Apr 2011 19:22:01 +0100
> On Thu, 2011-04-07 at 04:58 -0700, Amit Kumar Salecha wrote:
>> Ethtool support to configure RX, TX and other channels. combined field
>> in struct ethtool_channels to reflect set of channel (RX, TX or other).
>> Other channel can be link interrupts, SR-IOV coordination etc.
>>
>> ETHTOOL_GCHANNELS will report max and current number of RX channels,
>> max and current number of TX channels, max and current number of other channel
>> or max and current number of combined channel.
>>
>> Number of channel can be modify upto max number of channel through
>> ETHTOOL_SCHANNELS command.
>>
>> Ben Hutchings:
>> o define 'combined' and 'other' types. Most multiqueue drivers pair up RX and TX
>> queues so that most channels combine RX and TX work.
>> o Please could you use a kernel-doc comment to describe the structure.
>>
>> Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
> Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>
Applied, thanks everyone.
prev parent reply other threads:[~2011-04-13 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 11:58 [PATCHv4 NEXT 1/1] net: ethtool support to configure number of channels Amit Kumar Salecha
2011-04-13 9:45 ` Amit Salecha
2011-04-13 12:03 ` Ben Hutchings
2011-04-13 17:40 ` David Miller
2011-04-13 18:22 ` Ben Hutchings
2011-04-13 18:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110413.113124.59674252.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ameen.rahman@qlogic.com \
--cc=amit.salecha@qlogic.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=sucheta.chakraborty@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).