netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bruce Allan <bruce.w.allan@intel.com>
To: netdev@vger.kernel.org
Cc: Bruce Allan <bruce.w.allan@intel.com>,
	Sathya Perla <sathya.perla@emulex.com>,
	Subbu Seetharaman <subbu.seetharaman@emulex.com>,
	Ajit Khaparde <ajit.khaparde@emulex.com>
Subject: [net-next-2.6 RFC PATCH v2 02/13] benet: set ethtool set_phys_id on/off cycle frequency to 1/sec
Date: Wed, 13 Apr 2011 12:58:56 -0700	[thread overview]
Message-ID: <20110413195856.25901.87799.stgit@gitlad.jf.intel.com> (raw)
In-Reply-To: <20110413195146.25901.72193.stgit@gitlad.jf.intel.com>

Physical identification frequency based on how it was done prior to the
introduction of set_phys_id.  Compile tested only.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Cc: Sathya Perla <sathya.perla@emulex.com>
Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com>
Cc: Ajit Khaparde <ajit.khaparde@emulex.com>
---

 drivers/net/benet/be_ethtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/benet/be_ethtool.c b/drivers/net/benet/be_ethtool.c
index 96f5502..80226e4 100644
--- a/drivers/net/benet/be_ethtool.c
+++ b/drivers/net/benet/be_ethtool.c
@@ -516,7 +516,7 @@ be_set_phys_id(struct net_device *netdev,
 	case ETHTOOL_ID_ACTIVE:
 		be_cmd_get_beacon_state(adapter, adapter->hba_port_num,
 					&adapter->beacon_state);
-		return -EINVAL;
+		return 1;	/* cycle on/off once per second */
 
 	case ETHTOOL_ID_ON:
 		be_cmd_set_beacon_state(adapter, adapter->hba_port_num, 0, 0,


  parent reply	other threads:[~2011-04-13 19:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-13 19:58 [net-next-2.6 RFC PATCH v2 00/13] ethtool: allow custom interval for Bruce Allan
2011-04-13 19:58 ` [net-next-2.6 RFC PATCH v2 01/13] ethtool: allow custom interval for physical identification Bruce Allan
2011-04-13 20:25   ` Ben Hutchings
2011-04-13 22:39     ` Allan, Bruce W
2011-04-13 22:44       ` Ben Hutchings
2011-04-13 22:55         ` Allan, Bruce W
2011-04-13 19:58 ` Bruce Allan [this message]
2011-04-13 19:59 ` [net-next-2.6 RFC PATCH v2 03/13] bnx2: set ethtool set_phys_id on/off cycle frequency to 1/sec Bruce Allan
2011-04-13 19:59 ` [net-next-2.6 RFC PATCH v2 04/13] bnx2x: " Bruce Allan
2011-04-13 19:59 ` [net-next-2.6 RFC PATCH v2 05/13] cxgb3: " Bruce Allan
2011-04-13 19:59 ` [net-next-2.6 RFC PATCH v2 06/13] ewrk3: set ethtool set_phys_id on/off cycle frequency to 2/sec Bruce Allan
2011-04-13 19:59 ` [net-next-2.6 RFC PATCH v2 07/13] niu: set ethtool set_phys_id on/off cycle frequency to 1/sec Bruce Allan
2011-04-13 19:59 ` [net-next-2.6 RFC PATCH v2 08/13] pcnet32: set ethtool set_phys_id on/off cycle frequency to 2/sec Bruce Allan
2011-04-14 14:00   ` Don Fry
2011-04-13 19:59 ` [net-next-2.6 RFC PATCH v2 09/13] s2io: set ethtool set_phys_id on/off cycle frequency to 1/sec Bruce Allan
2011-04-13 19:59 ` [net-next-2.6 RFC PATCH v2 10/13] sfc: " Bruce Allan
2011-04-13 19:59 ` [net-next-2.6 RFC PATCH v2 11/13] skge: set ethtool set_phys_id on/off cycle frequency to 2/sec Bruce Allan
2011-04-13 19:59 ` [net-next-2.6 RFC PATCH v2 12/13] sky2: set ethtool set_phys_id on/off cycle frequency to 1/sec Bruce Allan
2011-04-13 21:00   ` Stephen Hemminger
2011-04-13 19:59 ` [net-next-2.6 RFC PATCH v2 13/13] tg3: " Bruce Allan
2011-04-13 20:11 ` [net-next-2.6 RFC PATCH v2 00/13] ethtool: allow custom interval for Ben Hutchings
2011-04-13 20:25   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110413195856.25901.87799.stgit@gitlad.jf.intel.com \
    --to=bruce.w.allan@intel.com \
    --cc=ajit.khaparde@emulex.com \
    --cc=netdev@vger.kernel.org \
    --cc=sathya.perla@emulex.com \
    --cc=subbu.seetharaman@emulex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).