From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Allan Subject: [net-next-2.6 RFC PATCH v2 13/13] tg3: set ethtool set_phys_id on/off cycle frequency to 1/sec Date: Wed, 13 Apr 2011 12:59:54 -0700 Message-ID: <20110413195954.25901.31005.stgit@gitlad.jf.intel.com> References: <20110413195146.25901.72193.stgit@gitlad.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Bruce Allan , Matt Carlson , Michael Chan To: netdev@vger.kernel.org Return-path: Received: from mga02.intel.com ([134.134.136.20]:18291 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758470Ab1DMUAB (ORCPT ); Wed, 13 Apr 2011 16:00:01 -0400 In-Reply-To: <20110413195146.25901.72193.stgit@gitlad.jf.intel.com> Sender: netdev-owner@vger.kernel.org List-ID: Physical identification frequency based on how it was done prior to the introduction of set_phys_id. Compile tested only. Signed-off-by: Bruce Allan Cc: Matt Carlson Cc: Michael Chan --- drivers/net/tg3.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 9d7defc..7c1a9dd 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -10292,7 +10292,7 @@ static int tg3_set_phys_id(struct net_device *dev, switch (state) { case ETHTOOL_ID_ACTIVE: - return -EINVAL; + return 1; /* cycle on/off once per second */ case ETHTOOL_ID_ON: tw32(MAC_LED_CTRL, LED_CTRL_LNKLED_OVERRIDE |