Re: [net-next-2.6 RFC PATCH v3] ethtool: allow custom interval for physical identification

[David Miller <davem@davemloft.net>]

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Fri, 15 Apr 2011 02:26:25 +0100

> On Wed, 2011-04-13 at 16:09 -0700, Bruce Allan wrote:
>> When physical identification of an adapter is done by toggling the
>> mechanism on and off through software utilizing the set_phys_id operation,
>> it is done with a fixed duration for both on and off states.  Some drivers
>> may want to set a custom duration for the on/off intervals.  This patch
>> changes the API so the return code from the driver's entry point when it
>> is called with ETHTOOL_ID_ACTIVE can specify the frequency at which to
>> cycle the on/off states, and updates the drivers that have already been
>> converted to use the new set_phys_id and use the synchronous method for
>> identifying an adapter.
>> 
>> The physical identification frequency set in the updated drivers is based
>> on how it was done prior to the introduction of set_phys_id.
>> 
>> Compile tested only.  Also fixes a compiler warning in sfc.
>> 
>> v2: drivers do not return -EINVAL for ETHOOL_ID_ACTIVE
>> v3: fold patchset into single patch and cleanup per Ben's feedback
>> 
>> Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
>> Cc: Ben Hutchings <bhutchings@solarflare.com>
> [...]
> Acked-by: Ben Hutchings <bhutchings@solarflare.com>

Applied, thanks everyone.