From: Krishna Kumar <krkumar2@in.ibm.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Krishna Kumar <krkumar2@in.ibm.com>
Subject: [PATCH v2] ip6_pol_route panic: Do not propagate LOOPBACK to VLAN
Date: Thu, 14 Apr 2011 21:37:17 +0530 [thread overview]
Message-ID: <20110414160717.32251.81326.sendpatchset@krkumar2.in.ibm.com> (raw)
In-Reply-To: <20110414160704.32251.17281.sendpatchset@krkumar2.in.ibm.com>
I have tested two ways of fixing this panic:
1. PATCH1: Do not allow vlan on lo.
2. PATCH2: Do not propagate LOOPBACK to vlan devices.
Isn't it better to use PATCH1 and disallow vlan on lo?
The result of this patch is:
# modprobe 8021q
# vconfig add lo 43
# ifconfig lo.69 hw ether 00:80:48:BA:d1:30
# ping6 -c 3 fe80::280:48ff:feba:d130
connect: Cannot assign requested address
(no panic)
Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
---
net/8021q/vlan_dev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -ruNp org/net/8021q/vlan_dev.c new2/net/8021q/vlan_dev.c
--- org/net/8021q/vlan_dev.c 2011-04-14 20:42:56.000000000 +0530
+++ new2/net/8021q/vlan_dev.c 2011-04-14 20:44:35.000000000 +0530
@@ -525,7 +525,8 @@ static int vlan_dev_init(struct net_devi
/* IFF_BROADCAST|IFF_MULTICAST; ??? */
dev->flags = real_dev->flags & ~(IFF_UP | IFF_PROMISC | IFF_ALLMULTI |
- IFF_MASTER | IFF_SLAVE);
+ IFF_MASTER | IFF_SLAVE |
+ IFF_LOOPBACK);
dev->iflink = real_dev->ifindex;
dev->state = (real_dev->state & ((1<<__LINK_STATE_NOCARRIER) |
(1<<__LINK_STATE_DORMANT))) |
next prev parent reply other threads:[~2011-04-14 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 16:07 [PATCH v1] ip6_pol_route panic: Do not allow VLAN on loopback Krishna Kumar
2011-04-14 16:07 ` Krishna Kumar [this message]
2011-04-18 6:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110414160717.32251.81326.sendpatchset@krkumar2.in.ibm.com \
--to=krkumar2@in.ibm.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).