From: Stephen Hemminger <shemminger@vyatta.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>,
"Michał Górny" <mgorny@gentoo.org>,
netdev@vger.kernel.org, roy@marples.name,
"Andy Gospodarek" <andy@greyhouse.net>
Subject: [RFC net-next] bonding: notify when bonding device address changes
Date: Fri, 15 Apr 2011 12:10:54 -0700 [thread overview]
Message-ID: <20110415121054.73717900@nehalam> (raw)
In-Reply-To: <10227.1302893590@death>
When a device changes its hardware address, it needs to call the network
device notifiers to inform protocols.
Compile tested only.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/bonding/bond_main.c 2011-04-15 11:21:02.142866195 -0700
+++ b/drivers/net/bonding/bond_main.c 2011-04-15 11:28:06.491408825 -0700
@@ -967,9 +967,11 @@ static void bond_do_fail_over_mac(struct
switch (bond->params.fail_over_mac) {
case BOND_FOM_ACTIVE:
- if (new_active)
+ if (new_active) {
memcpy(bond->dev->dev_addr, new_active->dev->dev_addr,
new_active->dev->addr_len);
+ call_netdevice_notifiers(NETDEV_CHANGEADDR, bond->dev);
+ }
break;
case BOND_FOM_FOLLOW:
/*
@@ -1386,6 +1388,7 @@ static int bond_sethwaddr(struct net_dev
pr_debug("slave_dev=%p\n", slave_dev);
pr_debug("slave_dev->addr_len=%d\n", slave_dev->addr_len);
memcpy(bond_dev->dev_addr, slave_dev->dev_addr, slave_dev->addr_len);
+ call_netdevice_notifiers(NETDEV_CHANGEADDR, bond_dev);
return 0;
}
@@ -1644,10 +1647,11 @@ int bond_enslave(struct net_device *bond
/* If this is the first slave, then we need to set the master's hardware
* address to be the same as the slave's. */
- if (is_zero_ether_addr(bond->dev->dev_addr))
+ if (is_zero_ether_addr(bond->dev->dev_addr)) {
memcpy(bond->dev->dev_addr, slave_dev->dev_addr,
slave_dev->addr_len);
-
+ call_netdevice_notifiers(NETDEV_CHANGEADDR, bond->dev);
+ }
new_slave = kzalloc(sizeof(struct slave), GFP_KERNEL);
if (!new_slave) {
@@ -2067,6 +2071,7 @@ int bond_release(struct net_device *bond
* to the mac address of the first slave
*/
memset(bond_dev->dev_addr, 0, bond_dev->addr_len);
+ call_netdevice_notifiers(NETDEV_CHANGEADDR, bond_dev);
if (!bond->vlgrp) {
bond_dev->features |= NETIF_F_VLAN_CHALLENGED;
@@ -2252,6 +2257,7 @@ static int bond_release_all(struct net_d
* first slave
*/
memset(bond_dev->dev_addr, 0, bond_dev->addr_len);
+ call_netdevice_notifiers(NETDEV_CHANGEADDR, bond_dev);
if (!bond->vlgrp) {
bond_dev->features |= NETIF_F_VLAN_CHALLENGED;
next prev parent reply other threads:[~2011-04-15 19:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 16:44 The bonding driver should notify userspace of MAC address change Michał Górny
2011-04-15 18:40 ` Nicolas de Pesloüan
2011-04-15 18:53 ` Jay Vosburgh
2011-04-15 19:10 ` Stephen Hemminger [this message]
2011-04-15 19:28 ` [RFC net-next] bonding: notify when bonding device address changes Jay Vosburgh
2011-04-16 16:18 ` Stephen Hemminger
2011-04-15 19:12 ` The bonding driver should notify userspace of MAC address change Phil Oester
2011-04-15 19:22 ` Jay Vosburgh
2011-04-15 19:22 ` Nicolas de Pesloüan
2011-04-15 21:45 ` Jay Vosburgh
2011-04-16 9:07 ` Nicolas de Pesloüan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110415121054.73717900@nehalam \
--to=shemminger@vyatta.com \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=mgorny@gentoo.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@gmail.com \
--cc=roy@marples.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox