* [PATCH net-next] bridge: fix accidental creation of sysfs directory
@ 2011-04-16 16:09 Stephen Hemminger
2011-04-18 0:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2011-04-16 16:09 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Commit bb900b27a2f49b37bc38c08e656ea13048fee13b introduced a bug in net-next
because of a typo in notifier. Every device would have the sysfs
bridge directory (and files).
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/bridge/br_notify.c 2011-04-16 08:56:06.130218417 -0700
+++ b/net/bridge/br_notify.c 2011-04-16 08:59:30.703509541 -0700
@@ -37,7 +37,7 @@ static int br_device_event(struct notifi
int err;
/* register of bridge completed, add sysfs entries */
- if ((dev->priv_flags && IFF_EBRIDGE) && event == NETDEV_REGISTER) {
+ if ((dev->priv_flags & IFF_EBRIDGE) && event == NETDEV_REGISTER) {
br_sysfs_addbr(dev);
return NOTIFY_DONE;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] bridge: fix accidental creation of sysfs directory
2011-04-16 16:09 [PATCH net-next] bridge: fix accidental creation of sysfs directory Stephen Hemminger
@ 2011-04-18 0:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-04-18 0:53 UTC (permalink / raw)
To: shemminger; +Cc: netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Sat, 16 Apr 2011 09:09:15 -0700
> Commit bb900b27a2f49b37bc38c08e656ea13048fee13b introduced a bug in net-next
> because of a typo in notifier. Every device would have the sysfs
> bridge directory (and files).
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied, thanks Stephen.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-18 0:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-16 16:09 [PATCH net-next] bridge: fix accidental creation of sysfs directory Stephen Hemminger
2011-04-18 0:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).