From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 0/42] Kill -Wunused-but-set warnings
Date: Sun, 17 Apr 2011 20:38:35 -0700 (PDT) [thread overview]
Message-ID: <20110417.203835.193727585.davem@davemloft.net> (raw)
In-Reply-To: <1303093155.5282.1009.camel@localhost>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 18 Apr 2011 03:19:15 +0100
> In most of these cases there is presumably no need for the variable at
> all. In others, the variable should have been used - which I believe is
> the main reason for the warning - and by removing it you will be hiding
> a bug.
If you look at about 5 or 6 of my patches, that's exactly what I did,
make use of the variable.
Otherwise I tossed it.
It seems I messed up the decnet case, which I'll fix shortly.
prev parent reply other threads:[~2011-04-18 3:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 0:32 [PATCH 0/42] Kill -Wunused-but-set warnings David Miller
2011-04-18 2:19 ` Ben Hutchings
2011-04-18 3:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110417.203835.193727585.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).