* [PATCH 0/42] Kill -Wunused-but-set warnings
@ 2011-04-18 0:32 David Miller
2011-04-18 2:19 ` Ben Hutchings
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2011-04-18 0:32 UTC (permalink / raw)
To: netdev
The weather is real nice, so I decided to lock myself inside and
fix compiler warnings.
I started using gcc-4.6.x on my primary sparc64 build test machine the
other week and it now enables -Wunused-but-set with -Wall and it does
catch a bunch of bogus stuff.
Most of the cases are where you'd expect them, ISDN and ATM.
This is the first pass I've made over the networking cases.
There's still a bunch more to do.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/42] Kill -Wunused-but-set warnings
2011-04-18 0:32 [PATCH 0/42] Kill -Wunused-but-set warnings David Miller
@ 2011-04-18 2:19 ` Ben Hutchings
2011-04-18 3:38 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ben Hutchings @ 2011-04-18 2:19 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On Sun, 2011-04-17 at 17:32 -0700, David Miller wrote:
> The weather is real nice, so I decided to lock myself inside and
> fix compiler warnings.
>
> I started using gcc-4.6.x on my primary sparc64 build test machine the
> other week and it now enables -Wunused-but-set with -Wall and it does
> catch a bunch of bogus stuff.
[...]
In most of these cases there is presumably no need for the variable at
all. In others, the variable should have been used - which I believe is
the main reason for the warning - and by removing it you will be hiding
a bug.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/42] Kill -Wunused-but-set warnings
2011-04-18 2:19 ` Ben Hutchings
@ 2011-04-18 3:38 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-04-18 3:38 UTC (permalink / raw)
To: bhutchings; +Cc: netdev
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 18 Apr 2011 03:19:15 +0100
> In most of these cases there is presumably no need for the variable at
> all. In others, the variable should have been used - which I believe is
> the main reason for the warning - and by removing it you will be hiding
> a bug.
If you look at about 5 or 6 of my patches, that's exactly what I did,
make use of the variable.
Otherwise I tossed it.
It seems I messed up the decnet case, which I'll fix shortly.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-18 3:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-18 0:32 [PATCH 0/42] Kill -Wunused-but-set warnings David Miller
2011-04-18 2:19 ` Ben Hutchings
2011-04-18 3:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).