From: David Miller <davem@davemloft.net>
To: jon.mason@myri.com
Cc: mirq-linux@rere.qmqm.pl, netdev@vger.kernel.org,
gallatin@myri.com, brice@myri.com
Subject: Re: [PATCH] net: myri10ge: convert to hw_features
Date: Sun, 17 Apr 2011 23:30:53 -0700 (PDT) [thread overview]
Message-ID: <20110417.233053.70188684.davem@davemloft.net> (raw)
In-Reply-To: <20110415182922.GA2458@myri.com>
From: Jon Mason <jon.mason@myri.com>
Date: Fri, 15 Apr 2011 13:29:22 -0500
> On Fri, Apr 15, 2011 at 04:50:50PM +0200, Michał Mirosław wrote:
>> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
>> ---
>> drivers/net/myri10ge/myri10ge.c | 66 +++++++-------------------------------
>> 1 files changed, 12 insertions(+), 54 deletions(-)
>>
>> diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
>> index 1446de5..a48eb92 100644
>> --- a/drivers/net/myri10ge/myri10ge.c
>> +++ b/drivers/net/myri10ge/myri10ge.c
>> @@ -205,7 +205,6 @@ struct myri10ge_priv {
>> int tx_boundary; /* boundary transmits cannot cross */
>> int num_slices;
>> int running; /* running? */
>> - int csum_flag; /* rx_csums? */
>
> Get rid of MXGEFW_FLAGS_CKSUM in drivers/net/myri10ge/myri10ge_mcp.h,
> as this was the only thing using it.
...
> ethtool_op_set_tso does not support TSO6. This would remove the
> enable/disable of that feature.
Michał please fix these issues and resubmit this patch, thanks!
next prev parent reply other threads:[~2011-04-18 6:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 14:50 [PATCH] net: myri10ge: convert to hw_features Michał Mirosław
2011-04-15 18:29 ` Jon Mason
2011-04-15 18:36 ` Andrew Gallatin
2011-04-15 18:47 ` Michał Mirosław
2011-04-18 6:30 ` David Miller [this message]
2011-04-18 11:03 ` Michał Mirosław
2011-04-18 14:24 ` Jon Mason
2011-04-19 5:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110417.233053.70188684.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brice@myri.com \
--cc=gallatin@myri.com \
--cc=jon.mason@myri.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).