* [PATCH] net: forcedeth: fix compile warning of not used nv_set_tso function
@ 2011-04-20 1:31 Shan Wei
2011-04-20 1:42 ` Shan Wei
2011-04-20 3:11 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Shan Wei @ 2011-04-20 1:31 UTC (permalink / raw)
To: mirq-linux, David Miller, netdev
Fix the below compile warning:
drivers/net/forcedeth.c:4266: warning: ‘nv_set_tso’ defined but not used
commit 569e146 converts forcedeth driver to use hw_features.
So, implement function of .set_tso is abandoned.
Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
---
drivers/net/forcedeth.c | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index ec9a32d..0e1c76a 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -4263,16 +4263,6 @@ static int nv_nway_reset(struct net_device *dev)
return ret;
}
-static int nv_set_tso(struct net_device *dev, u32 value)
-{
- struct fe_priv *np = netdev_priv(dev);
-
- if ((np->driver_data & DEV_HAS_CHECKSUM))
- return ethtool_op_set_tso(dev, value);
- else
- return -EOPNOTSUPP;
-}
-
static void nv_get_ringparam(struct net_device *dev, struct ethtool_ringparam* ring)
{
struct fe_priv *np = netdev_priv(dev);
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: forcedeth: fix compile warning of not used nv_set_tso function
2011-04-20 1:31 [PATCH] net: forcedeth: fix compile warning of not used nv_set_tso function Shan Wei
@ 2011-04-20 1:42 ` Shan Wei
2011-04-20 3:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Shan Wei @ 2011-04-20 1:42 UTC (permalink / raw)
To: mirq-linux, David Miller, netdev
This patch is against net-next.
Shan Wei wrote, at 04/20/2011 09:31 AM:
> Fix the below compile warning:
> drivers/net/forcedeth.c:4266: warning: ‘nv_set_tso’ defined but not used
>
> commit 569e146 converts forcedeth driver to use hw_features.
> So, implement function of .set_tso is abandoned.
>
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
> ---
> drivers/net/forcedeth.c | 10 ----------
> 1 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
> index ec9a32d..0e1c76a 100644
> --- a/drivers/net/forcedeth.c
> +++ b/drivers/net/forcedeth.c
> @@ -4263,16 +4263,6 @@ static int nv_nway_reset(struct net_device *dev)
> return ret;
> }
>
> -static int nv_set_tso(struct net_device *dev, u32 value)
> -{
> - struct fe_priv *np = netdev_priv(dev);
> -
> - if ((np->driver_data & DEV_HAS_CHECKSUM))
> - return ethtool_op_set_tso(dev, value);
> - else
> - return -EOPNOTSUPP;
> -}
> -
> static void nv_get_ringparam(struct net_device *dev, struct ethtool_ringparam* ring)
> {
> struct fe_priv *np = netdev_priv(dev);
--
Best Regards
-----
Shan Wei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: forcedeth: fix compile warning of not used nv_set_tso function
2011-04-20 1:31 [PATCH] net: forcedeth: fix compile warning of not used nv_set_tso function Shan Wei
2011-04-20 1:42 ` Shan Wei
@ 2011-04-20 3:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2011-04-20 3:11 UTC (permalink / raw)
To: shanwei; +Cc: mirq-linux, netdev
From: Shan Wei <shanwei@cn.fujitsu.com>
Date: Wed, 20 Apr 2011 09:31:20 +0800
> Fix the below compile warning:
> drivers/net/forcedeth.c:4266: warning: ‘nv_set_tso’ defined but not used
>
> commit 569e146 converts forcedeth driver to use hw_features.
> So, implement function of .set_tso is abandoned.
>
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-20 3:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-20 1:31 [PATCH] net: forcedeth: fix compile warning of not used nv_set_tso function Shan Wei
2011-04-20 1:42 ` Shan Wei
2011-04-20 3:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).