* [PATCH] ehea: Fix a DLPAR bug on ehea_rereg_mrs().
@ 2011-04-19 19:39 Breno Leitao
2011-04-20 8:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Breno Leitao @ 2011-04-19 19:39 UTC (permalink / raw)
To: davem; +Cc: netdev, Breno Leitao
We are currently continuing if ehea_restart_qps() fails, when we
do a memory DLPAR (remove or add more memory to the system).
This patch just let the NAPI disabled if the ehea_restart_qps()
fails.
Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
---
drivers/net/ehea/ehea_main.c | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
index f75d314..53c0f04 100644
--- a/drivers/net/ehea/ehea_main.c
+++ b/drivers/net/ehea/ehea_main.c
@@ -3040,11 +3040,14 @@ static void ehea_rereg_mrs(void)
if (dev->flags & IFF_UP) {
mutex_lock(&port->port_lock);
- port_napi_enable(port);
ret = ehea_restart_qps(dev);
- check_sqs(port);
- if (!ret)
+ if (!ret) {
+ check_sqs(port);
+ port_napi_enable(port);
netif_wake_queue(dev);
+ } else {
+ netdev_err(dev, "Unable to restart QPS\n");
+ }
mutex_unlock(&port->port_lock);
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ehea: Fix a DLPAR bug on ehea_rereg_mrs().
2011-04-19 19:39 [PATCH] ehea: Fix a DLPAR bug on ehea_rereg_mrs() Breno Leitao
@ 2011-04-20 8:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-04-20 8:42 UTC (permalink / raw)
To: leitao; +Cc: netdev
From: Breno Leitao <leitao@linux.vnet.ibm.com>
Date: Tue, 19 Apr 2011 16:39:22 -0300
> We are currently continuing if ehea_restart_qps() fails, when we
> do a memory DLPAR (remove or add more memory to the system).
>
> This patch just let the NAPI disabled if the ehea_restart_qps()
> fails.
>
> Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-20 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-19 19:39 [PATCH] ehea: Fix a DLPAR bug on ehea_rereg_mrs() Breno Leitao
2011-04-20 8:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).