From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: dmitry@broadcom.com, eilong@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH] bnx2x: dont dereference tcp header on non tcp frames
Date: Wed, 20 Apr 2011 01:46:57 -0700 (PDT) [thread overview]
Message-ID: <20110420.014657.232735224.davem@davemloft.net> (raw)
In-Reply-To: <1303284713.3186.13.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 20 Apr 2011 09:31:53 +0200
> [PATCH] bnx2x: dont dereference tcp header on non tcp frames
>
> bnx2x_set_pbd_csum() & bnx2x_set_pbd_csum_e2() use
> tcp_hdrlen(skb) even for non TCP frames
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Broadcom folks please review.
next prev parent reply other threads:[~2011-04-20 8:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 16:11 [BUG] bnx2x: bnx2x_set_pbd_csum() random accesses Eric Dumazet
2011-04-20 7:31 ` [PATCH] bnx2x: dont dereference tcp header on non tcp frames Eric Dumazet
2011-04-20 8:46 ` David Miller [this message]
2011-04-20 9:40 ` Dmitry Kravkov
2011-04-20 15:08 ` Dmitry Kravkov
2011-04-22 0:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110420.014657.232735224.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).