From: Dave Jones <davej@redhat.com>
To: netdev@vger.kernel.org
Subject: ipqueue allocation failure.
Date: Tue, 19 Apr 2011 21:42:22 -0400 [thread overview]
Message-ID: <20110420014221.GC26949@redhat.com> (raw)
Not catastrophic, but ipqueue seems to be too trusting of what it gets
passed from userspace, and passes it on down to the page allocator,
where it will spew warnings if the page order is too high.
__ipq_rcv_skb has several checks for lengths too small, but doesn't
seem to have any for oversized ones. I'm not sure what the maximum
we should check for is. I'll code up a diff if anyone has any ideas
on a sane maximum.
Dave
------------[ cut here ]------------
WARNING: at mm/page_alloc.c:2032 __alloc_pages_nodemask+0x17d/0x7e6()
Hardware name: GA-MA78GM-S2H
Modules linked in: rfcomm hidp can_raw can_bcm sctp libcrc32c ip_queue decnet pppoe pppox ppp_generic slhc can ipx p8022 p8023 phonet bluetooth rfkill a]
Pid: 20393, comm: trinity Not tainted 2.6.39-rc4+ #6
Call Trace:
[<ffffffff81056a9c>] warn_slowpath_common+0x83/0x9b
[<ffffffff81056ace>] warn_slowpath_null+0x1a/0x1c
[<ffffffff810ed743>] __alloc_pages_nodemask+0x17d/0x7e6
[<ffffffff811206c9>] ? check_object+0x174/0x1ae
[<ffffffff81120a43>] ? check_slab+0xc7/0xd5
[<ffffffff813f42fe>] ? __alloc_skb+0x40/0x133
[<ffffffff813f42fe>] ? __alloc_skb+0x40/0x133
[<ffffffff814b7487>] kmalloc_large_node+0x56/0x95
[<ffffffff811235c1>] __kmalloc_node_track_caller+0x32/0x139
[<ffffffff81421b68>] ? netlink_ack+0x4a/0xe8
[<ffffffffa0500475>] ? ipq_rcv_skb+0x27/0x340 [ip_queue]
[<ffffffff813f4333>] __alloc_skb+0x75/0x133
[<ffffffff81421b68>] netlink_ack+0x4a/0xe8
[<ffffffffa050076a>] ipq_rcv_skb+0x31c/0x340 [ip_queue]
[<ffffffff8142174a>] netlink_unicast+0xec/0x156
[<ffffffff81421a33>] netlink_sendmsg+0x27f/0x2c0
[<ffffffff813ed76c>] __sock_sendmsg+0x69/0x75
[<ffffffff813ed834>] sock_aio_write+0xbc/0xcc
[<ffffffff8113242b>] do_sync_write+0xbf/0xff
[<ffffffff81206e18>] ? security_file_permission+0x2e/0x33
[<ffffffff81132861>] ? rw_verify_area+0xb6/0xd3
[<ffffffff81132b02>] vfs_write+0xb6/0xf6
[<ffffffff8113400b>] ? fget_light+0x3a/0xa1
[<ffffffff81132cf6>] sys_write+0x4d/0x74
[<ffffffff814c5d82>] system_call_fastpath+0x16/0x1b
---[ end trace cd56dc75cfeab436 ]---
next reply other threads:[~2011-04-20 1:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 1:42 Dave Jones [this message]
2011-04-20 3:41 ` ipqueue allocation failure David Miller
2011-04-20 5:27 ` Eric Dumazet
2011-05-28 0:36 ` [PATCH] Use unsigned variables for packet lengths in ip[6]_queue Dave Jones
2011-06-02 19:24 ` Dave Jones
2011-06-02 20:57 ` David Miller
2011-06-07 12:59 ` Patrick McHardy
2011-06-07 14:19 ` Patrick McHardy
2011-06-07 14:39 ` Dave Jones
2011-06-07 15:19 ` Patrick McHardy
2011-06-03 10:07 ` Pablo Neira Ayuso
2011-04-21 15:13 ` ipqueue allocation failure Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110420014221.GC26949@redhat.com \
--to=davej@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).