From: Greg KH <gregkh@suse.de>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: octeon-ethernet: remove .get_sg, etc. ethtool_ops
Date: Wed, 20 Apr 2011 07:36:12 -0700 [thread overview]
Message-ID: <20110420143612.GA22661@suse.de> (raw)
In-Reply-To: <20110420142553.D497813909@rere.qmqm.pl>
On Wed, Apr 20, 2011 at 04:25:53PM +0200, Michał Mirosław wrote:
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
> drivers/staging/octeon/ethernet-mdio.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c
> index 10a82ef..8a11ffc 100644
> --- a/drivers/staging/octeon/ethernet-mdio.c
> +++ b/drivers/staging/octeon/ethernet-mdio.c
> @@ -91,8 +91,6 @@ const struct ethtool_ops cvm_oct_ethtool_ops = {
> .set_settings = cvm_oct_set_settings,
> .nway_reset = cvm_oct_nway_reset,
> .get_link = ethtool_op_get_link,
> - .get_sg = ethtool_op_get_sg,
> - .get_tx_csum = ethtool_op_get_tx_csum,
> };
Why are you doing this? Please explain it better in the changelog and
resend this.
thanks,
greg k-h
next prev parent reply other threads:[~2011-04-20 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 14:25 [PATCH] staging: octeon-ethernet: remove .get_sg, etc. ethtool_ops Michał Mirosław
2011-04-20 14:36 ` Greg KH [this message]
2011-04-20 16:27 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110420143612.GA22661@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).