* [PATCH] staging: octeon-ethernet: remove .get_sg, etc. ethtool_ops
@ 2011-04-20 14:25 Michał Mirosław
2011-04-20 14:36 ` Greg KH
2011-04-20 16:27 ` Michał Mirosław
0 siblings, 2 replies; 3+ messages in thread
From: Michał Mirosław @ 2011-04-20 14:25 UTC (permalink / raw)
To: netdev; +Cc: Greg Kroah-Hartman, devel
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
---
drivers/staging/octeon/ethernet-mdio.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c
index 10a82ef..8a11ffc 100644
--- a/drivers/staging/octeon/ethernet-mdio.c
+++ b/drivers/staging/octeon/ethernet-mdio.c
@@ -91,8 +91,6 @@ const struct ethtool_ops cvm_oct_ethtool_ops = {
.set_settings = cvm_oct_set_settings,
.nway_reset = cvm_oct_nway_reset,
.get_link = ethtool_op_get_link,
- .get_sg = ethtool_op_get_sg,
- .get_tx_csum = ethtool_op_get_tx_csum,
};
/**
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: octeon-ethernet: remove .get_sg, etc. ethtool_ops
2011-04-20 14:25 [PATCH] staging: octeon-ethernet: remove .get_sg, etc. ethtool_ops Michał Mirosław
@ 2011-04-20 14:36 ` Greg KH
2011-04-20 16:27 ` Michał Mirosław
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2011-04-20 14:36 UTC (permalink / raw)
To: Michał Mirosław; +Cc: netdev, devel
On Wed, Apr 20, 2011 at 04:25:53PM +0200, Michał Mirosław wrote:
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
> drivers/staging/octeon/ethernet-mdio.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c
> index 10a82ef..8a11ffc 100644
> --- a/drivers/staging/octeon/ethernet-mdio.c
> +++ b/drivers/staging/octeon/ethernet-mdio.c
> @@ -91,8 +91,6 @@ const struct ethtool_ops cvm_oct_ethtool_ops = {
> .set_settings = cvm_oct_set_settings,
> .nway_reset = cvm_oct_nway_reset,
> .get_link = ethtool_op_get_link,
> - .get_sg = ethtool_op_get_sg,
> - .get_tx_csum = ethtool_op_get_tx_csum,
> };
Why are you doing this? Please explain it better in the changelog and
resend this.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] staging: octeon-ethernet: remove .get_sg, etc. ethtool_ops
2011-04-20 14:25 [PATCH] staging: octeon-ethernet: remove .get_sg, etc. ethtool_ops Michał Mirosław
2011-04-20 14:36 ` Greg KH
@ 2011-04-20 16:27 ` Michał Mirosław
1 sibling, 0 replies; 3+ messages in thread
From: Michał Mirosław @ 2011-04-20 16:27 UTC (permalink / raw)
To: netdev; +Cc: Greg Kroah-Hartman, devel
Driver sets .get_sg and .get_tx_csum ethtool_ops to their default
values anyway. Those fields are deprecated, starting in 2.6.39.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
---
drivers/staging/octeon/ethernet-mdio.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c
index 10a82ef..8a11ffc 100644
--- a/drivers/staging/octeon/ethernet-mdio.c
+++ b/drivers/staging/octeon/ethernet-mdio.c
@@ -91,8 +91,6 @@ const struct ethtool_ops cvm_oct_ethtool_ops = {
.set_settings = cvm_oct_set_settings,
.nway_reset = cvm_oct_nway_reset,
.get_link = ethtool_op_get_link,
- .get_sg = ethtool_op_get_sg,
- .get_tx_csum = ethtool_op_get_tx_csum,
};
/**
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-20 16:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-20 14:25 [PATCH] staging: octeon-ethernet: remove .get_sg, etc. ethtool_ops Michał Mirosław
2011-04-20 14:36 ` Greg KH
2011-04-20 16:27 ` Michał Mirosław
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).