From: David Miller <davem@davemloft.net>
To: berny156@gmx.de
Cc: eric.dumazet@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: Oops in 2.6.39 include/net/dst.h: dst_metrics_write_ptr() running l2tp over ipsec
Date: Mon, 25 Apr 2011 11:54:29 -0700 (PDT) [thread overview]
Message-ID: <20110425.115429.193701951.davem@davemloft.net> (raw)
In-Reply-To: <4DB54450.90806@gmx.de>
From: Held Bernhard <berny156@gmx.de>
Date: Mon, 25 Apr 2011 11:52:16 +0200
> Am 25.04.2011 10:07, schrieb Eric Dumazet:
>> From: Held Bernhard<berny156@gmx.de>
...
>> Thanks for your report and patch.
>>
>> Maybe following patch is the way to fix this, please test it.
>>
>>
>> [PATCH] net: provide cow_metrics() methods to blackhole dst_ops
...
>> The oops happens in dst_metrics_write_ptr()
>> include/net/dst.h:124: return dst->ops->cow_metrics(dst, p);
>>
>> dst->ops->cow_metrics is NULL and causes the oops.
>>
>> Provide cow_metrics() methods, like we did in commit 214f45c91bb
>> (net: provide default_advmss() methods to blackhole dst_ops)
>>
>> Signed-off-by: Held Bernhard<berny156@gmx.de>
>> Signed-off-by: Eric Dumazet<eric.dumazet@gmail.com>
...
> Your patch works flawlessly.
>
> Thanks for the quick response!
Applied, thanks everyone.
prev parent reply other threads:[~2011-04-25 18:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-24 22:37 Oops in 2.6.39 include/net/dst.h: dst_metrics_write_ptr() running l2tp over ipsec Held Bernhard
2011-04-25 8:07 ` Eric Dumazet
2011-04-25 9:52 ` Held Bernhard
2011-04-25 12:49 ` Eric Dumazet
2011-04-25 18:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110425.115429.193701951.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=berny156@gmx.de \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).