From: David Miller <davem@davemloft.net>
To: david.ward@ll.mit.edu
Cc: netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH 2/2] macvlan: Send frames to AF_PACKET sockets attached to lowerdev
Date: Wed, 27 Apr 2011 23:09:51 -0700 (PDT) [thread overview]
Message-ID: <20110427.230951.260093496.davem@davemloft.net> (raw)
In-Reply-To: <1303392693-1350-3-git-send-email-david.ward@ll.mit.edu>
From: David Ward <david.ward@ll.mit.edu>
Date: Thu, 21 Apr 2011 09:31:33 -0400
> dest = macvlan_hash_lookup(port, eth->h_dest);
> if (dest && dest->mode == MACVLAN_MODE_BRIDGE) {
> + dev_queue_xmit_nit(skb, vlan->lowerdev);
> unsigned int length = skb->len + ETH_HLEN;
> int ret = dest->forward(dest->dev, skb);
> macvlan_count_rx(dest, length,
Don't put actual code before variable declarations in a basic
block, modern variants of C accept this but this isn't C++.
prev parent reply other threads:[~2011-04-28 6:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 13:31 [PATCH 0/2] Resolve packet capturing on macvlan lowerdev David Ward
2011-04-21 13:31 ` [PATCH 1/2] net: Export dev_queue_xmit_nit for use by macvlan driver David Ward
2011-04-21 13:31 ` [PATCH 2/2] macvlan: Send frames to AF_PACKET sockets attached to lowerdev David Ward
2011-04-28 6:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110427.230951.260093496.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.ward@ll.mit.edu \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).