From: David Miller <davem@davemloft.net>
To: mcarlson@broadcom.com
Cc: joe@perches.com, mchan@broadcom.com, eric.dumazet@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] tg3: Convert u32 flag,flg2,flg3 uses to bitmap
Date: Thu, 28 Apr 2011 13:42:41 -0700 (PDT) [thread overview]
Message-ID: <20110428.134241.70176095.davem@davemloft.net> (raw)
In-Reply-To: <20110427162821.GA9762@mcarlson.broadcom.com>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Wed, 27 Apr 2011 09:28:21 -0700
> On Tue, Apr 26, 2011 at 11:12:10AM -0700, Joe Perches wrote:
>> Using a bitmap instead of separate u32 flags allows a consistent, simpler
>> and more extensible mechanism to determine capabilities.
>>
>> Convert bitmasks to enum.
>> Add tg3_flag, tg3_flag_clear and tg3_flag_set.
>> Convert the flag & bitmask tests.
>>
>> Signed-off-by: Joe Perches <joe@perches.com>
>
> I looked through it and didn't see any problems. I've queued
> Michael Chan's suggestion into my queue.
>
> Acked-by: Matt Carlson <mcarlson@broadcom.com>
I've applied Joe's change to net-next-2.6, thanks everyone.
next prev parent reply other threads:[~2011-04-28 20:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 22:42 [PATCH net-next 0/6] tg3: TSO loopback and EEH support Matt Carlson
2011-04-26 7:25 ` David Miller
[not found] ` <1303776118.24299.1.camel@Joe-Laptop>
[not found] ` <20110426001738.GB802@mcarlson.broadcom.com>
[not found] ` <1303776574.24299.3.camel@Joe-Laptop>
[not found] ` <20110426013512.GA2031@mcarlson.broadcom.com>
2011-04-26 18:12 ` [PATCH] tg3: Convert u32 flag,flg2,flg3 uses to bitmap Joe Perches
2011-04-26 19:49 ` David Miller
2011-04-27 16:28 ` Matt Carlson
2011-04-28 20:42 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-20 17:57 [PATCH net-next 9/9] tg3: Add additional EEE messaging Matt Carlson
2011-04-21 6:39 ` [PATCH] tg3: Convert u32 flag,flg2,flg3 uses to bitmap Joe Perches
2011-04-21 6:52 ` Joe Perches
2011-04-21 8:31 ` Eric Dumazet
2011-04-21 16:49 ` Joe Perches
2011-04-21 17:18 ` Michael Chan
2011-04-21 17:51 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110428.134241.70176095.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).