From: David Miller <davem@davemloft.net>
To: netdev@vger.kernel.org
Subject: [PATCH 1/10] ipv4: Remove now superfluous code in ip_route_connect().
Date: Fri, 29 Apr 2011 10:26:54 -0700 (PDT) [thread overview]
Message-ID: <20110429.102654.71099871.davem@davemloft.net> (raw)
Now that output route lookups update the flow with
source address et al. selections, the fl4->{saddr,daddr}
assignments here are no longer necessary.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
include/net/route.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/include/net/route.h b/include/net/route.h
index 81b6cf2..16eb59c 100644
--- a/include/net/route.h
+++ b/include/net/route.h
@@ -271,8 +271,6 @@ static inline struct rtable *ip_route_connect(struct flowi4 *fl4,
rt = __ip_route_output_key(net, fl4);
if (IS_ERR(rt))
return rt;
- fl4->daddr = rt->rt_dst;
- fl4->saddr = rt->rt_src;
ip_rt_put(rt);
}
security_sk_classify_flow(sk, flowi4_to_flowi(fl4));
--
1.7.4.5
reply other threads:[~2011-04-29 17:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110429.102654.71099871.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).