netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/10] ipv4: Remove now superfluous code in ip_route_connect().
@ 2011-04-29 17:26 David Miller
  0 siblings, 0 replies; only message in thread
From: David Miller @ 2011-04-29 17:26 UTC (permalink / raw)
  To: netdev


Now that output route lookups update the flow with
source address et al. selections, the fl4->{saddr,daddr}
assignments here are no longer necessary.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 include/net/route.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/include/net/route.h b/include/net/route.h
index 81b6cf2..16eb59c 100644
--- a/include/net/route.h
+++ b/include/net/route.h
@@ -271,8 +271,6 @@ static inline struct rtable *ip_route_connect(struct flowi4 *fl4,
 		rt = __ip_route_output_key(net, fl4);
 		if (IS_ERR(rt))
 			return rt;
-		fl4->daddr = rt->rt_dst;
-		fl4->saddr = rt->rt_src;
 		ip_rt_put(rt);
 	}
 	security_sk_classify_flow(sk, flowi4_to_flowi(fl4));
-- 
1.7.4.5


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2011-04-29 17:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-29 17:26 [PATCH 1/10] ipv4: Remove now superfluous code in ip_route_connect() David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).