* Re: linux-next: Tree for April 29 (bpf_jit) [not found] <20110429131940.4f4c938f.sfr@canb.auug.org.au> @ 2011-04-29 16:26 ` Randy Dunlap 2011-04-29 17:19 ` Eric Dumazet 0 siblings, 1 reply; 3+ messages in thread From: Randy Dunlap @ 2011-04-29 16:26 UTC (permalink / raw) To: Stephen Rothwell, netdev; +Cc: linux-next, LKML On Fri, 29 Apr 2011 13:19:40 +1000 Stephen Rothwell wrote: > Hi all, > > Changes since 20110428: when CONFIG_MODULES is not enabled: bpf_jit_comp.c:(.text+0x43cc2): undefined reference to `module_free' (.text+0x4521a): undefined reference to `module_alloc' (.text+0x453af): undefined reference to `module_free' --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for April 29 (bpf_jit) 2011-04-29 16:26 ` linux-next: Tree for April 29 (bpf_jit) Randy Dunlap @ 2011-04-29 17:19 ` Eric Dumazet 2011-04-29 17:21 ` David Miller 0 siblings, 1 reply; 3+ messages in thread From: Eric Dumazet @ 2011-04-29 17:19 UTC (permalink / raw) To: Randy Dunlap, David Miller; +Cc: Stephen Rothwell, netdev, linux-next, LKML Le vendredi 29 avril 2011 à 09:26 -0700, Randy Dunlap a écrit : > On Fri, 29 Apr 2011 13:19:40 +1000 Stephen Rothwell wrote: > > > Hi all, > > > > Changes since 20110428: > > > when CONFIG_MODULES is not enabled: > > bpf_jit_comp.c:(.text+0x43cc2): undefined reference to `module_free' > (.text+0x4521a): undefined reference to `module_alloc' > (.text+0x453af): undefined reference to `module_free' > > Oh well, I guess we can add one 'depends on MODULES' like we do for KPROBES (it also uses module_alloc()) Not sure many people build a !CONFIG_MODULES kernel these days... Thanks Randy ! [PATCH net-next-2.6] bpf: depends on MODULES module_alloc() and module_free() are available only if CONFIG_MODULES=y Reported-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- net/Kconfig | 1 + 1 files changed, 1 insertion(+) diff --git a/net/Kconfig b/net/Kconfig index 745fb02..878151c 100644 --- a/net/Kconfig +++ b/net/Kconfig @@ -238,6 +238,7 @@ config HAVE_BPF_JIT config BPF_JIT bool "enable BPF Just In Time compiler" depends on HAVE_BPF_JIT + depends on MODULES ---help--- Berkeley Packet Filter filtering capabilities are normally handled by an interpreter. This option allows kernel to generate a native ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for April 29 (bpf_jit) 2011-04-29 17:19 ` Eric Dumazet @ 2011-04-29 17:21 ` David Miller 0 siblings, 0 replies; 3+ messages in thread From: David Miller @ 2011-04-29 17:21 UTC (permalink / raw) To: eric.dumazet; +Cc: randy.dunlap, sfr, netdev, linux-next, linux-kernel From: Eric Dumazet <eric.dumazet@gmail.com> Date: Fri, 29 Apr 2011 19:19:18 +0200 > [PATCH net-next-2.6] bpf: depends on MODULES > > module_alloc() and module_free() are available only if CONFIG_MODULES=y > > Reported-by: Randy Dunlap <randy.dunlap@oracle.com> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Applied, thanks. Perhaps we can solve these things by seperating out the dependency, via "CONFIG_MODULE_ALLOC" and making things like KPROBES and BPF 'select' it. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-29 17:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110429131940.4f4c938f.sfr@canb.auug.org.au>
2011-04-29 16:26 ` linux-next: Tree for April 29 (bpf_jit) Randy Dunlap
2011-04-29 17:19 ` Eric Dumazet
2011-04-29 17:21 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).