From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next-2.6] veth: remove unneeded ifname code from veth_newlink() Date: Sat, 30 Apr 2011 12:16:48 +0200 Message-ID: <20110430101647.GC2658@psychotron.orion> References: <20110124154546.GA2689@psychotron.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netdev@vger.kernel.org, davem@davemloft.net, xemul@openvz.org To: =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41620 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755479Ab1D3KQy (ORCPT ); Sat, 30 Apr 2011 06:16:54 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: =46ri, Apr 22, 2011 at 11:49:40AM CEST, mirqus@gmail.com wrote: >W dniu 22 kwietnia 2011 11:43 u=C5=BCytkownik Micha=C5=82 Miros=C5=82a= w > napisa=C5=82: >> 2011/1/24 Jiri Pirko : >>> The code is not needed because tb[IFLA_IFNAME] is already >>> processed in rtnl_newlink(). Remove this redundancy. >> Hi. This patch broke creation of veth devices. Reverting it fixes th= e issue. >> >> Symptoms: >> >> icybox:~# ip link add type veth >> RTNETLINK answers: File exists >> icybox:~# ip link add type veth peer veth1 >> icybox:~# ip addr >> [...] >> 56: D: mtu 1500 qdisc noop state DOWN qlen 100= 0 >> =C2=A0 =C2=A0link/ether e6:57:58:52:03:50 brd ff:ff:ff:ff:ff:ff >> 57: veth0: mtu 1500 qdisc noop state DOWN qlen= 1000 >> =C2=A0 =C2=A0link/ether c2:c2:a2:d5:d5:3a brd ff:ff:ff:ff:ff:ff > >Hmm. I was too quick. Reverting it fixes only first problem - "ip link >add type veth" adds new veth pair now, but "ip link add type veth peer >veth1" gives the same result as above. I gusee you should do: ip link add type veth peer name veth1 > >Best Regards, >Micha=C5=82 Miros=C5=82aw