From: David Miller <davem@davemloft.net>
To: agimenez@sysvalve.es
Cc: linux-kernel@vger.kernel.org, dgiagio@gmail.com,
dborca@yahoo.com, pmcenery@gmail.com, david.hill@ubisoft.com,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] ipheth.c: Enable IP header alignment
Date: Mon, 02 May 2011 12:46:22 -0700 (PDT) [thread overview]
Message-ID: <20110502.124622.226785624.davem@davemloft.net> (raw)
In-Reply-To: <1304364912-15444-1-git-send-email-agimenez@sysvalve.es>
From: L. Alberto Giménez <agimenez@sysvalve.es>
Date: Mon, 2 May 2011 21:35:12 +0200
> Since commit ea812ca1b06113597adcd8e70c0f84a413d97544 (x86: Align skb w/ start
> of cacheline on newer core 2/Xeon Arch), NET_IP_ALIGN changed from 2 to 0, and
> the constant is used to reserve more room for the socket buffer.
>
> Some people have reported that tethering stopped working and David Hill
> submited a patch that redefined NET_IP_ALIGN. Pointed by Ben Hutchings, the
> patch has been reworked to use a private constant.
>
> I have no more an iPhone device to test it, so it is only compile-tested.
>
> Signed-off-by: L. Alberto Giménez <agimenez@sysvalve.es>
Why did this break things?
I'm not applying a fix when nobody can explain the reason why:
1) Things broke in the first place
2) Forcing reservation of 2 bytes fixes things
Where is the built in assumption about "2" and why does it exist? Why
can't we fix this code not to have such assumptions in the first
place?
next prev parent reply other threads:[~2011-05-02 19:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-01 11:00 [PATCH] ipheth.c: Enable IP header alignment L. Alberto Giménez
[not found] ` <1304247656-21086-1-git-send-email-agimenez-lqZFv/KUvpAxAGwisGp4zA@public.gmane.org>
2011-05-01 15:46 ` Ben Hutchings
2011-05-02 19:35 ` L. Alberto Giménez
2011-05-02 19:46 ` David Miller [this message]
2011-05-02 21:12 ` L. Alberto Giménez
2011-05-02 21:04 ` Ben Hutchings
2011-05-03 16:57 ` L. Alberto Giménez
[not found] ` <20110503165751.GA6566-vFZw08TITM7wxNmfbb4FQRs6BjWItJ1b@public.gmane.org>
2011-05-03 17:18 ` David Hill
2011-05-03 17:33 ` Paul McEnery
2011-05-03 17:41 ` David Hill
2011-05-03 22:45 ` Paul McEnery
2011-05-03 17:49 ` [PATCH net-next-2.6] ipheth: Properly distinguish length and alignment in URBs and skbs Ben Hutchings
2011-05-08 22:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502.124622.226785624.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=agimenez@sysvalve.es \
--cc=david.hill@ubisoft.com \
--cc=dborca@yahoo.com \
--cc=dgiagio@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmcenery@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).