From: David Miller <davem@davemloft.net>
To: viresh.kumar@st.com
Cc: peppe.cavallaro@st.com, netdev@vger.kernel.org,
shiraz.hashim@st.com, armando.visconti@st.com,
deepak.sikri@st.com, viresh.linux@gmail.com
Subject: Re: [PATCH] linux/stmmac.h: include <linux/platform_device.h> to remove compilation warning.
Date: Mon, 02 May 2011 15:01:19 -0700 (PDT) [thread overview]
Message-ID: <20110502.150119.183038069.davem@davemloft.net> (raw)
In-Reply-To: <2239eca1d15014be7b6d94f883f9492dc1fbc60a.1304317552.git.viresh.kumar@st.com>
From: Viresh Kumar <viresh.kumar@st.com>
Date: Mon, 2 May 2011 12:00:37 +0530
> stmmac.h uses struct platform_device and doesn't include
> <linux/platform_device.h>. And so we get following compilation warning while
> using this file:
> warning: ‘struct platform_device’ declared inside parameter list
>
> This patch includes <linux/platform_device.h> in stmmac.h to remove this warning
>
> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
This patch applies to neither net-2.6, nor net-next-2.6
The context around your change in all current trees looks a lot
different than what's in your patch.
In fact, even if I go through the entire history in GIT of this
header file, those STMAC_TYPE_0 defines are never there.
The string "STMAC_TYPE_0" doesn't even show up in a query to google
code search.
What tree are you even patching against?
next prev parent reply other threads:[~2011-05-02 22:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 6:30 [PATCH] linux/stmmac.h: include <linux/platform_device.h> to remove compilation warning Viresh Kumar
2011-05-02 12:46 ` Giuseppe CAVALLARO
2011-05-03 3:45 ` viresh kumar
2011-05-02 22:01 ` David Miller [this message]
2011-05-03 3:44 ` viresh kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502.150119.183038069.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=armando.visconti@st.com \
--cc=deepak.sikri@st.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=shiraz.hashim@st.com \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).