From: David Miller <davem@davemloft.net>
To: dmitry@broadcom.com
Cc: netdev@vger.kernel.org, vladz@broadcom.com, eilong@broadcom.com
Subject: Re: [net-next 1/5] bnx2x: link report improvements
Date: Tue, 03 May 2011 16:05:08 -0700 (PDT) [thread overview]
Message-ID: <20110503.160508.226773770.davem@davemloft.net> (raw)
In-Reply-To: <1304429925.19456.11.camel@lb-tlvb-dmitry>
From: "Dmitry Kravkov" <dmitry@broadcom.com>
Date: Tue, 3 May 2011 16:38:45 +0300
> From: Vladislav Zolotarov <vladz@broadcom.com>
>
> To avoid link notification duplications
>
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
> Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
You go through all of the effort to use atomic bit operations
on the link state statue flags, then do a memcpy() to propagate
new state into the software state structure which is not atomic.
Either it needs to be atomic or it does not.
If it doesn't use __set_bit() and friends and document exactly
what synchronizes and protects access to this object.
next prev parent reply other threads:[~2011-05-03 23:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 13:38 [net-next 1/5] bnx2x: link report improvements Dmitry Kravkov
2011-05-03 23:05 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-03-20 16:28 Dmitry Kravkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503.160508.226773770.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vladz@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).