From: David Miller <davem@davemloft.net>
To: dmitry@broadcom.com
Cc: netdev@vger.kernel.org, eilong@broadcom.com
Subject: Re: [net-next 4/5] bnx2x: improve memory handling, low memory recovery flows
Date: Tue, 03 May 2011 16:07:01 -0700 (PDT) [thread overview]
Message-ID: <20110503.160701.71113763.davem@davemloft.net> (raw)
In-Reply-To: <1304429337.19456.5.camel@lb-tlvb-dmitry>
From: "Dmitry Kravkov" <dmitry@broadcom.com>
Date: Tue, 3 May 2011 16:28:57 +0300
>
> +/**
> + * zeros the contents of the bp->fp[index].
> + * Makes sure the contents of the bp->fp[index]. napi is kept
> + * intact.
> + *
> + * @param bp
> + * @param index
> + */
I should have caught this in the past but I've only noticed it right
now.
Do not use your own, custom, format for documenting functions and
their arguments.
Use the standard DocBook comment format we use in the entire kernel.
The last thing we need is every single driver using their own custom
format.
Fix up the existing cases, or remove them completely.
Thanks.
prev parent reply other threads:[~2011-05-03 23:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 13:28 [net-next 4/5] bnx2x: improve memory handling, low memory recovery flows Dmitry Kravkov
2011-05-03 23:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503.160701.71113763.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).