From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: viresh.kumar@st.com, netdev@vger.kernel.org,
shiraz.hashim@st.com, armando.visconti@st.com,
deepak.sikri@st.com, viresh.linux@gmail.com
Subject: Re: [PATCH V2] net/stmmac: Move "#include <linux/platform_device.h>" to linux/stmmac.h
Date: Tue, 03 May 2011 16:09:57 -0700 (PDT) [thread overview]
Message-ID: <20110503.160957.104053064.davem@davemloft.net> (raw)
In-Reply-To: <4DBF9477.5070302@st.com>
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Tue, 03 May 2011 07:36:55 +0200
> On 5/3/2011 6:36 AM, Viresh Kumar wrote:
>> stmmac.h uses struct platform_device and doesn't include
>> <linux/platform_device.h>. Whereas drivers/net/stmmac/stmmac.h includes it, but
>> doesn't directly use it. And so we get following compilation warning while using
>> this file:
>> warning: ‘struct platform_device’ declared inside parameter list
>>
>> This patch includes <linux/platform_device.h> in linux/stmmac.h and removes it
>> from drivers/net/stmmac/stmmac.h
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
>
> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Applied to net-next-2.6, thanks everyone.
prev parent reply other threads:[~2011-05-03 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 4:36 [PATCH V2] net/stmmac: Move "#include <linux/platform_device.h>" to linux/stmmac.h Viresh Kumar
2011-05-03 5:36 ` Giuseppe CAVALLARO
2011-05-03 23:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503.160957.104053064.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=armando.visconti@st.com \
--cc=deepak.sikri@st.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=shiraz.hashim@st.com \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).