From: Oliver Neukum <oneukum@suse.de>
To: Joe Perches <joe@perches.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usbnet: Style cleanups
Date: Tue, 3 May 2011 20:49:41 +0200 [thread overview]
Message-ID: <201105032049.41433.oneukum@suse.de> (raw)
In-Reply-To: <3592918df9ee156047042aae16531e96db0b7144.1304445019.git.joe@perches.com>
Am Dienstag, 3. Mai 2011, 20:17:57 schrieb Joe Perches:
> drivers/net/usb/usbnet.c | 625 +++++++++++++++++++++++----------------------
> 1 files changed, 319 insertions(+), 306 deletions(-)
>
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index 7bc9852..28aecbb 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -30,8 +30,8 @@
> * issues can usefully be addressed by this framework.
> */
>
> -// #define DEBUG // error path messages, extra info
> -// #define VERBOSE // more; success messages
> +/* #define DEBUG // error path messages, extra info */
> +/* #define VERBOSE // more; success messages */
Hi,
1. please don't touch things like that. They are not comments in a semantic sense
2. If you are touching comments, please redo the multiline comments according to
the coding style.
3. please delay these modifications until the patches against the oom problem have
been applied
Regards
Oliver
--
- - -
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
Maxfeldstraße 5
90409 Nürnberg
Germany
- - -
next prev parent reply other threads:[~2011-05-03 18:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 18:17 [PATCH 0/2] usbnet: style cleaning and logging Joe Perches
2011-05-03 18:17 ` [PATCH 1/2] usbnet: Style cleanups Joe Perches
2011-05-03 18:49 ` Oliver Neukum [this message]
2011-05-03 19:05 ` Joe Perches
2011-05-03 18:17 ` [PATCH 2/2] usbnet: Convert dbg to dev_dbg and neatening Joe Perches
2011-05-03 18:51 ` Oliver Neukum
2011-05-04 11:35 ` Sergei Shtylyov
2011-05-04 12:11 ` Joe Perches
2011-05-04 12:42 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105032049.41433.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).