From: David Miller <davem@davemloft.net>
To: shanwei@cn.fujitsu.com
Cc: netdev@vger.kernel.org, eilong@broadcom.com, dm@chelsio.com,
leedom@chelsio.com, mirqus@gmail.com, bhutchings@solarflare.com
Subject: Re: [PATCH 1/2] net: use NETIF_F_ALL_TSO for vlan features
Date: Thu, 05 May 2011 10:53:50 -0700 (PDT) [thread overview]
Message-ID: <20110505.105350.183065364.davem@davemloft.net> (raw)
In-Reply-To: <4DBA4AB4.5000802@cn.fujitsu.com>
From: Shan Wei <shanwei@cn.fujitsu.com>
Date: Fri, 29 Apr 2011 13:20:52 +0800
>
> As Dimitris Michailidis suggested, use NETIF_F_ALL_TSO for vlan_features,
> which is a mask, but not hw_features.
>
> Compile test.
>
>
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
I do not understand why we want to advertise a set of ->vlan_features
TSO flags that are different from the flags advertised in ->hw_features.
Why do we want to do this?
next prev parent reply other threads:[~2011-05-05 17:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 5:20 [PATCH 1/2] net: use NETIF_F_ALL_TSO for vlan features Shan Wei
2011-05-05 17:53 ` David Miller [this message]
2011-05-05 18:19 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505.105350.183065364.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=dm@chelsio.com \
--cc=eilong@broadcom.com \
--cc=leedom@chelsio.com \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shanwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).