From: David Miller <davem@davemloft.net>
To: shanwei@cn.fujitsu.com
Cc: netdev@vger.kernel.org, rusty@rustcorp.com.au, mst@redhat.com,
eric.dumazet@gmail.com, mirq-linux@rere.qmqm.pl,
mirqus@gmail.com, bhutchings@solarflare.com, dm@chelsio.com
Subject: Re: [PATCH 2/2 net-next] net: drivers: set TSO/UFO offload option explicitly
Date: Thu, 05 May 2011 10:54:51 -0700 (PDT) [thread overview]
Message-ID: <20110505.105451.39198990.davem@davemloft.net> (raw)
In-Reply-To: <4DBA4DF5.5020101@cn.fujitsu.com>
From: Shan Wei <shanwei@cn.fujitsu.com>
Date: Fri, 29 Apr 2011 13:34:45 +0800
> The device drivers should not use NETIF_F_ALL_TSO mask to set hw_features(or features),
> but have to explicitly set offload option. Because, This would make drivers automatically
> clain to support any new TSO feature an the moment of NETIF_F_ALL_TSO is expanded.
>
> Some code style tuning. Just compile test.
>
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
But loopback is special. It can support anything the kernel stack can emit.
So for loopback, using NETIF_F_ALL_TSO is in fact appropriate.
prev parent reply other threads:[~2011-05-05 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 5:34 [PATCH 2/2 net-next] net: drivers: set TSO/UFO offload option explicitly Shan Wei
2011-05-04 12:36 ` Michał Mirosław
2011-05-05 8:51 ` Shan Wei
2011-05-05 17:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505.105451.39198990.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=dm@chelsio.com \
--cc=eric.dumazet@gmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mirqus@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=shanwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).