From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Yi Zou <yi.zou@intel.com>
Cc: netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com, devel@open-fcoe.org
Subject: Re: [PATCH] [RFC] vlan: fix updating wanted_features for vlan device
Date: Thu, 5 May 2011 08:51:53 +0200 [thread overview]
Message-ID: <20110505065153.GA3288@rere.qmqm.pl> (raw)
In-Reply-To: <20110505004841.26691.74872.stgit@localhost6.localdomain6>
On Wed, May 04, 2011 at 05:48:42PM -0700, Yi Zou wrote:
> commit 8a0427b "vlan: convert VLAN devices to use ndo_fix_features()" converts the
> vlan to support ndo_fix_features. However, the wanted_features is not updated
> for the vlan device, causing real_dev->features not be populated to the vlan
> device when real_dev->features are changed by the driver through FEAT_CHANGE.
> This is breaking FCoE related netdev feature flags on vlan devices. Add updating
> wanted_features to vlan_transfer_features() so netdev_get_wanted_features() will
> can get the updated wanted feature flags for vlan device properly.
Can you describe the situation further? There might be problems if device
changes its vlan_features after creation of VLAN devices on top (bonding?).
dev->wanted_features is only what user wants to get and should not be changed
by anything else.
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2011-05-05 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 0:48 [PATCH] [RFC] vlan: fix updating wanted_features for vlan device Yi Zou
2011-05-05 6:51 ` Michał Mirosław [this message]
2011-05-05 7:49 ` Zou, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505065153.GA3288@rere.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=devel@open-fcoe.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=yi.zou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox