Re: [PATCH] [RFC] vlan: fix updating wanted_features for vlan device

Michał Mirosław
2011-05-05T06:51:55Z

On Wed, May 04, 2011 at 05:48:42PM -0700, Yi Zou wrote:
> commit 8a0427b "vlan: convert VLAN devices to use ndo_fix_features()" converts the
> vlan to support ndo_fix_features. However, the wanted_features is not updated
> for the vlan device, causing real_dev->features not be populated to the vlan
> device when real_dev->features are changed by the driver through FEAT_CHANGE.
> This is breaking FCoE related netdev feature flags on vlan devices. Add updating
> wanted_features to vlan_transfer_features() so netdev_get_wanted_features() will
> can get the updated wanted feature flags for vlan device properly.

Can you describe the situation further? There might be problems if device
changes its vlan_features after creation of VLAN devices on top (bonding?).

dev->wanted_features is only what user wants to get and should not be changed
by anything else.

Best Regards,
Michał Mirosław