From: David Miller <davem@davemloft.net>
To: gerrit@erg.abdn.ac.uk
Cc: drosenberg@vsecurity.com, dccp@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
security@kernel.org
Subject: Re: [PATCH] dccp: handle invalid feature options length
Date: Fri, 06 May 2011 13:04:47 -0700 (PDT) [thread overview]
Message-ID: <20110506.130447.183054252.davem@davemloft.net> (raw)
In-Reply-To: <20110506195733.GA3527@gerrit.erg.abdn.ac.uk>
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Fri, 6 May 2011 21:57:33 +0200
> Quoting Dan Rosenberg:
> | A length of zero (after subtracting two for the type and len fields) for
> | the DCCPO_{CHANGE,CONFIRM}_{L,R} options will cause an underflow due to
> | the subtraction. The subsequent code may read past the end of the
> | options value buffer when parsing. I'm unsure of what the consequences
> | of this might be, but it's probably not good.
> |
> Please disregard my earlier message, I erred.
> Dan is right, his patch is correct and definitively valid.
> A length of 0 would be cast to 0xff and then cause buffer overrun.
>
> | Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
> | Cc: stable@kernel.org
> Acked-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Great, I'll apply this, thanks!
prev parent reply other threads:[~2011-05-06 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 13:27 [PATCH] dccp: handle invalid feature options length Dan Rosenberg
2011-05-06 13:53 ` Gerrit Renker
2011-05-06 14:43 ` Dan Rosenberg
2011-05-06 19:57 ` Gerrit Renker
2011-05-06 20:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110506.130447.183054252.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=drosenberg@vsecurity.com \
--cc=gerrit@erg.abdn.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).