From: David Miller <davem@davemloft.net>
To: scottjg@vmware.com
Cc: sbhatewara@vmware.com, roland@kernel.org, pv-drivers@vmware.com,
netdev@vger.kernel.org
Subject: Re: [Pv-drivers] [PATCH] vmxnet3: Consistently disable irqs when taking adapter->cmd_lock
Date: Fri, 06 May 2011 13:12:11 -0700 (PDT) [thread overview]
Message-ID: <20110506.131211.39193090.davem@davemloft.net> (raw)
In-Reply-To: <F78BCF638F95D74A99D036114107EDB5028EFAA0F8@EXCH-MBX-3.vmware.com>
From: Scott Goldman <scottjg@vmware.com>
Date: Fri, 6 May 2011 13:10:29 -0700
>>
>> On Fri, 6 May 2011, Roland Dreier wrote:
>>
>> > From: Roland Dreier <roland@purestorage.com>
>> >
>> > Using the vmxnet3 driver produces a lockdep warning because
>>
>> > Signed-off-by: Roland Dreier <roland@purestorage.com>
>>
>>
>> Roland, thanks for the analysis and the patch.
>>
>> Signed-off-by: Shreyas N Bhatewara <sbhatewara@vmware.com>
>
> Likewise, seems pretty sane to me. The command register operations are only control-path operations and disabling interrupts for the duration is probably not a big deal. Touching the cmd reg will result a VMEXIT, where the guest won't be processing interrupts anyway.
>
> Signed-off-by: Scott J. Goldman <scottjg@vmware.com>
Applied, thanks everyone.
prev parent reply other threads:[~2011-05-06 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 18:32 [PATCH] vmxnet3: Consistently disable irqs when taking adapter->cmd_lock Roland Dreier
2011-05-06 19:21 ` Shreyas Bhatewara
2011-05-06 20:10 ` [Pv-drivers] " Scott Goldman
2011-05-06 20:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110506.131211.39193090.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=roland@kernel.org \
--cc=sbhatewara@vmware.com \
--cc=scottjg@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).