netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: netdev@vger.kernel.org
Subject: [PATCH 0/15] Pass keys down to ip_queue_xmit()
Date: Sun, 08 May 2011 15:37:18 -0700 (PDT)	[thread overview]
Message-ID: <20110508.153718.226797622.davem@davemloft.net> (raw)


The final goal of this set of changes is to normalize all uses
of ip_queue_xmit() and how sockets are connected up so that
ip_queue_xmit() can elide it's usage of rt->rt_{src,dst}

Along the way I found some locking problems in L2TP fixed here.

Basically we reuse inet_sk->cork.fl to store keying information
and pass that (or something more appropriate) to ip_queue_xmit()

This opens up the door for SCTP to express exactly what is does, by
passing in a flow which is now added to the individual transport
instances.

Taking this one step further, we could add a "struct dst **dst"
argument to ->queue_xmit() and friends, then SCTP could pass in
"&transport->dst" and it would no longer need to do that special
"pre-hookup the DST to skb" uglyness.

L2TP could be modified similarly.

Then the pre-routed SKB code can be removed completely.

Signed-off-by: David S. Miller <davem@davemloft.net>

                 reply	other threads:[~2011-05-08 22:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110508.153718.226797622.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).