From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: pull request: batman-adv 2011-05-08 Date: Sun, 08 May 2011 15:40:06 -0700 (PDT) Message-ID: <20110508.154006.70211034.davem@davemloft.net> References: <1304868284-9364-1-git-send-email-sven@narfation.org> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org To: sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org Return-path: In-Reply-To: <1304868284-9364-1-git-send-email-sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org Errors-To: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org List-Id: netdev.vger.kernel.org From: Sven Eckelmann Date: Sun, 8 May 2011 17:24:36 +0200 > Hi, > > I would like to propose following patches for net-next-2.6/2.6.40. They > include minor cleanups of comments, a big rename patch s/hna/tt/, but > also a remove some duplicated code. The spinlock which protected the > list of possible interfaces for batman-adv was completely replaced by > rtnl_lock because we want to be in sync with the rest of the network > stack and the extra spinlock made everything more complex without giving > any additional feature (and rtnl_lock was already used everywhere). > Related to this patch is also a fix which should prevent a deadlock > between the sysfs code and the event listener. Also the reference > counting in find_router was fixed when an error was detected after the > refcounter was already increased. The only feature is the support for > multiple vlans in the bridge loop detection code. > > I will submit a patch to remove the atomic_dec_not_zero from main.h > after Linus accepted the patch you already saw. Pulled, thanks Sven.