From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: david.hill@ubisoft.com, agimenez@sysvalve.es,
linux-kernel@vger.kernel.org, dgiagio@gmail.com,
dborca@yahoo.com, pmcenery@gmail.com, linux-usb@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] ipheth: Properly distinguish length and alignment in URBs and skbs
Date: Sun, 08 May 2011 15:46:22 -0700 (PDT) [thread overview]
Message-ID: <20110508.154622.35028516.davem@davemloft.net> (raw)
In-Reply-To: <1304444965.2873.11.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 03 May 2011 18:49:25 +0100
> The USB protocol this driver implements appears to require 2 bytes of
> padding in front of each received packet. This used to be equal to
> the value of NET_IP_ALIGN on x86, so the driver abused that constant
> and mostly worked, but this is no longer the case. The driver also
> mixed up the URB and packet lengths, resulting in 2 bytes of junk at
> the end of the skb.
>
> Introduce a private constant for the 2 bytes of padding; fix this
> confusion and check for the under-length case.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> Compile-tested only, as I'm not cool enough for an iPhone either.
> This is applicable to net-next-2.6 or v2.6.38.
I've applied this to net-2.6 and will conditionally queue it up for
-stable, if we need further fixups we can add relative patches.
Thanks.
prev parent reply other threads:[~2011-05-08 22:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-01 11:00 [PATCH] ipheth.c: Enable IP header alignment L. Alberto Giménez
[not found] ` <1304247656-21086-1-git-send-email-agimenez-lqZFv/KUvpAxAGwisGp4zA@public.gmane.org>
2011-05-01 15:46 ` Ben Hutchings
2011-05-02 19:35 ` L. Alberto Giménez
2011-05-02 19:46 ` David Miller
2011-05-02 21:12 ` L. Alberto Giménez
2011-05-02 21:04 ` Ben Hutchings
2011-05-03 16:57 ` L. Alberto Giménez
[not found] ` <20110503165751.GA6566-vFZw08TITM7wxNmfbb4FQRs6BjWItJ1b@public.gmane.org>
2011-05-03 17:18 ` David Hill
2011-05-03 17:33 ` Paul McEnery
2011-05-03 17:41 ` David Hill
2011-05-03 22:45 ` Paul McEnery
2011-05-03 17:49 ` [PATCH net-next-2.6] ipheth: Properly distinguish length and alignment in URBs and skbs Ben Hutchings
2011-05-08 22:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110508.154622.35028516.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=agimenez@sysvalve.es \
--cc=bhutchings@solarflare.com \
--cc=david.hill@ubisoft.com \
--cc=dborca@yahoo.com \
--cc=dgiagio@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmcenery@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).