From: David Miller <davem@davemloft.net>
To: maheshb@google.com
Cc: netdev@vger.kernel.org, therbert@google.com
Subject: Re: [PATCHv2] forcedeth: Allow ethtool to enable/disable loopback.
Date: Sun, 08 May 2011 15:57:59 -0700 (PDT) [thread overview]
Message-ID: <20110508.155759.200382648.davem@davemloft.net> (raw)
In-Reply-To: <1304559400-16257-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Wed, 4 May 2011 18:36:40 -0700
> @@ -4502,6 +4549,9 @@ static int nv_set_features(struct net_device *dev, u32 features)
>
> spin_unlock_irq(&np->lock);
> }
> + if ((changed & NETIF_F_LOOPBACK) && netif_running(dev)) {
> + nv_set_loopback(dev, features);
> + }
>
Please do not create a braced basic block just for a single
line of code. Simply:
> + if ((changed & NETIF_F_LOOPBACK) && netif_running(dev))
> + nv_set_loopback(dev, features);
is sufficient.
prev parent reply other threads:[~2011-05-08 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 1:22 [PATCHv1] forcedeth: Allow ethtool to enable/disable loopback Mahesh Bandewar
2011-05-05 1:36 ` [PATCHv2] " Mahesh Bandewar
2011-05-08 22:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110508.155759.200382648.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).