From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] ipv4: Pass flow keys down into datagram packet building engine.
Date: Sun, 08 May 2011 21:07:49 -0700 (PDT) [thread overview]
Message-ID: <20110508.210749.193695681.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.30.1105081811570.26257-100000@mail.perches.com>
From: Joe Perches <joe@perches.com>
Date: Sun, 8 May 2011 18:14:46 -0700 (PDT)
> On Sun, 8 May 2011, David Miller wrote:
>> +static struct rtable *icmp_route_lookup(struct net *net,
>> + struct flowi4 *fl4,
>> + struct sk_buff *skb_in,
>> const struct iphdr *iph,
>> __be32 saddr, u8 tos,
>> int type, int code,
>> struct icmp_bxm *param)
>> {
> []
>> + memset(&fl4, 0, sizeof(fl4));
>
> memset(fl4, 0, sizeof(*fl4));
>
>> + fl4->daddr = (param->replyopts.opt.opt.srr ?
>> + param->replyopts.opt.opt.faddr : iph->saddr);
>
Thanks Joe :-/ I'll fix that.
prev parent reply other threads:[~2011-05-09 4:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 1:07 [PATCH 1/2] ipv4: Pass flow keys down into datagram packet building engine David Miller
2011-05-09 1:14 ` Joe Perches
2011-05-09 4:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110508.210749.193695681.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).