From: David Miller <davem@davemloft.net>
To: mirq-linux@rere.qmqm.pl
Cc: netdev@vger.kernel.org, shemminger@linux-foundation.org,
kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, eric.dumazet@gmail.com,
therbert@google.com, bhutchings@solarflare.com,
bridge@lists.linux-foundation.org
Subject: Re: [RFC PATCH] net: fold dev_disable_lro() into netdev_fix_features()
Date: Mon, 09 May 2011 12:08:11 -0700 (PDT) [thread overview]
Message-ID: <20110509.120811.246541047.davem@davemloft.net> (raw)
In-Reply-To: <20110507114803.0D80A13A6B@rere.qmqm.pl>
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: Sat, 7 May 2011 13:48:02 +0200 (CEST)
> This moves checks that device is forwarding from bridge, IPv4 and IPv6
> code into netdev_fix_features(). As a side effect, after device is no longer
> forwarding it gets LRO back. This also means that user is not allowed to
> enable LRO after device is put to forwarding mode.
>
> This patch depends on removal of discrete offload setting ethtool ops.
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
We need to keep the check in the protocols because we don't want to
be testing protocol specific device state in generic code like
net/core/dev.c
next prev parent reply other threads:[~2011-05-09 19:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 11:48 [RFC PATCH] net: fold dev_disable_lro() into netdev_fix_features() Michał Mirosław
2011-05-09 19:08 ` David Miller [this message]
2011-05-12 16:06 ` Michał Mirosław
2011-05-12 16:06 ` [RFC PATCH v2] " Michał Mirosław
2011-05-12 16:29 ` Ben Hutchings
2011-05-12 16:35 ` Michał Mirosław
2011-05-12 16:57 ` Stephen Hemminger
2011-05-12 16:37 ` [RFC PATCH v3] " Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509.120811.246541047.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=bridge@lists.linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=shemminger@linux-foundation.org \
--cc=therbert@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).