From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 5/4] tulip: xircom_cb: Remove useless func_enter and func_exit Date: Mon, 09 May 2011 12:10:26 -0700 (PDT) Message-ID: <20110509.121026.28826727.davem@davemloft.net> References: <20110509.114706.189685729.davem@davemloft.net> <1304968081.19586.66.camel@Joe-Laptop> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: joe@perches.com Return-path: In-Reply-To: <1304968081.19586.66.camel@Joe-Laptop> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Joe Perches Date: Mon, 09 May 2011 12:08:01 -0700 > On Mon, 2011-05-09 at 11:47 -0700, David Miller wrote: >> With the advent of the function tracer, those silly function entry/exit >> logging things are entirely superfluous. >> They make the code look ugly too. > > I don't much like a lot of debugging messages > throughout drivers/net, but that's a whole 'nother > set of patches. > >> Please do that and respin this patch set, thanks Joe! > > How 'bout I just add another patch to delete them. > > Signed-off-by: Joe Perches How about you just respin the patch set as I asked you to? It makes no sense to "fix" something you're just going to delete in the very next commit.